Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code optimisation #279

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

piglig
Copy link
Contributor

@piglig piglig commented Jul 1, 2023

  1. [env/server/server.go] strings.Contains instead of strings.Index
  2. [extension/file_test.go] type assertion to the same type
  3. [storage/event_dispatch.go] simplifying error checking
  4. [storage/repository.go] when checking the length of map[string]interface{}, the nil check can be ignored
  5. code comment formatting

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2023

感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。

@coveralls
Copy link

coveralls commented Jul 26, 2023

Pull Request Test Coverage Report for Build 5428784400

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 18 (66.67%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 74.078%

Changes Missing Coverage Covered Lines Changed/Added Lines %
env/server/server.go 0 1 0.0%
storage/repository.go 11 16 68.75%
Files with Coverage Reduction New Missed Lines %
storage/repository.go 2 76.59%
Totals Coverage Status
Change from base Build 4328954728: 0.07%
Covered Lines: 1286
Relevant Lines: 1736

💛 - Coveralls

@zouyx zouyx changed the base branch from master to develop July 26, 2023 01:51
@mergify mergify bot merged commit 0e5d4ca into apolloconfig:develop Jul 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants