+tblish/+internal/mycombvec.m: Fix syntax error #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spaces ` ` separate elements inside brackets `[ ]`. So, that line is
interpreted as
out = [out; [repmat, (a(i), [size, (rest_combs,1), 1]), rest_combs]];
Combining comma-separated lists with parenthesis is not supported (and is probably not what was intended).
Fix the syntax error by removing the space between function name and
opening parenthesis inside brackets.
|
Oh, shoot; I didn't even see that you had already submitted a PR for this. I'm sorry! I already checked in a fix for this in 151d2ec, which covers this Would you mind re-testing against HEAD of |
|
No worries. I didn't check the codebase. Just reacted on the test error on gnu-octave/packages#401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spaces
[ ]. So, that line is interpreted asCombining comma-separated lists with parenthesis is not supported (and is probably not what was intended).
Fix the syntax errorby removing the space between function name and opening parenthesis inside brackets.
See the failing doctest: gnu-octave/packages#401
Andrew's notes
See also: #127