Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Add a value example to mock #514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

T-Kay
Copy link

@T-Kay T-Kay commented Jun 23, 2017

Add a value example to mock

@whitlockjc
Copy link
Member

This should probably be enabled via some option. Do you mind updating your PR to have a middleware option to enable this? Also, some tests would be nice as well.

@whitlockjc
Copy link
Member

Would you mind adding a test for this?

@farrago
Copy link

farrago commented Oct 19, 2017

This appears to do the same thing as #304, which already includes unit tests and has also had quite a bit of discussion.

Perhaps you could consider landing #304 instead of / as well as this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants