-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Uri parameters in vars expression #142
Draft
boekkooi-lengoo
wants to merge
9
commits into
api7:master
Choose a base branch
from
boekkooi-lengoo:parameters-vars
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Jan 8, 2024
-
This will allow us to use the matched params as part of the vars later.
Configuration menu - View commit details
-
Copy full SHA for 796828b - Browse repository at this point
Copy the full SHA 796828bView commit details -
This adds `uri_param_<name>` allowing vars and filters access to the parameters of a uri. By doing this we are able to improve validation of routes to specific params.
Configuration menu - View commit details
-
Copy full SHA for c767551 - Browse repository at this point
Copy the full SHA c767551View commit details -
As match_route_opts now handles both the opts and params we can set the matched information in match_route_opts to avoid some duplicate code.
Configuration menu - View commit details
-
Copy full SHA for a454f56 - Browse repository at this point
Copy the full SHA a454f56View commit details -
It seems `setmetatable` is very slow and was destroying the benchmark. For this reason we now use `clone_tab` and add the uri matches.
Configuration menu - View commit details
-
Copy full SHA for 2b9f67d - Browse repository at this point
Copy the full SHA 2b9f67dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f673ca6 - Browse repository at this point
Copy the full SHA f673ca6View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd7af11 - Browse repository at this point
Copy the full SHA dd7af11View commit details
Commits on Jan 12, 2024
-
There is no need to return `nil` as this is the default so let's avoid adding it.
Configuration menu - View commit details
-
Copy full SHA for c32baae - Browse repository at this point
Copy the full SHA c32baaeView commit details
Commits on Jan 23, 2024
-
Handle __index metamethod properly
[table.clone](https://github.com/openresty/luajit2#tableclone) won't copy metamethods. So in order to avoid any issues the [__index](https://www.lua.org/pil/13.4.1.html) metamethod is added to the new ops_vars.
Configuration menu - View commit details
-
Copy full SHA for 22f0010 - Browse repository at this point
Copy the full SHA 22f0010View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5ed57b - Browse repository at this point
Copy the full SHA d5ed57bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.