feature: implemented new lease-related api

[Yiyiyimu]

Fix #65

1. implement lease-related api
2. add test file
3. add documentation

also fixed a naming typo

[CLAassistant]

All committers have signed the CLA.

[membphis]

@Yiyiyimu please take a look at the output of Travis-CI .

[Yiyiyimu]

Hi @membphis I'm still working on the errors of other etcd versions. Is there anyway to set it to WIP? Or I just need to convert it to draft?

Also to deal with test in multi-version etcd locally, I'm trying to build dockerfile to automate the test process. Do you think that's necessary? Or that's not a big deal for others that building docker on my own is enough?

[membphis]

@Yiyiyimu I have updated the title, you can continue your job now.

you can remove WIP after you complete this feature.

[Yiyiyimu]

Thank you @membphis ! Do you have any suggestions on test of multi-version etcd locally?

[membphis]

Thank you @membphis ! Do you have any suggestions on test of multi-version etcd locally?

we can run the specified etcd at our local machine, and try to find the bug. you can take a look at the travis script, it is useful.

[Yiyiyimu]

Fix two problems:

1. the different API of lease-related function in multi-version
2. leases() is only supported after v3.4

Actually leases() is supported in v3.3.12, as etcd documentation shows. Since currently we deploy v3.3.0, I test it only in v3.4.0 and add another file lease3.4.t.

Considering this kind of problem could be common in the future, and this kind of naming is lack of readability, is there any need to build different branches in this repo according to different versions of etcd?

[Yiyiyimu]

we can run the specified etcd at our local machine, and try to find the bug. you can take a look at the travis script, it is useful.

Thank you @membphis it works!

[nic-chen]

should get the val between seted and expired, such as 1 or 1.5 second after seated.

[Yiyiyimu]

fixed

[nic-chen]

Need more keys to test

[Yiyiyimu]

Fixed. Test on attaching multiple keys to one lease, and using revoke to delete them all.

[nic-chen]

Why compare after slept? I’m confused about this.

[Yiyiyimu]

It's my fault. I add sleep after the comparison but forget to delete the comparison.

Also, I changed testing logic here from read TTL parameter to get key after default expired time.

[nic-chen]

Need more keys too

[Yiyiyimu]

Fixed. Test on separately attaching two keys to two leases, keepalive one and to see if one alive and another one expired.

[Yiyiyimu]

Improve test file in:

1. multiple leases
2. multiple keys attached to one lease
3. the keys responded from timetolive are the same to granted (add decoding)
4. manually assign ID when grant lease

---

It seems one v2 test file which I seems didn't change failed, I'll have a look on it.

[Yiyiyimu]

It seems one v2 test file which I seems didn't change failed, I'll have a look on it.

Same with #12

[Yiyiyimu]

Do we need to add the response structure of each API in doc, like only the body part, as mentioned in #37

For example timetolive

# +  body = {
# +    ID = "1",
# +    TTL = "2",
# +    grantedTTL = "3",
# +    header = {
# +      cluster_id = "14841639068965178418",
# +      member_id = "10276657743932975437",
# +      raft_term = "2",
# +      revision = "199"
# +    },
# +    keys = { "/test1" }
# +  },

and get

# +  body = {
# +    count = "1",
# +    header = {
# +      cluster_id = "14841639068965178418",
# +      member_id = "10276657743932975437",
# +      raft_term = "2",
# +      revision = "184"
# +    },
# +    kvs = { {
# +        create_revision = "184",
# +        key = "/test2",
# +        lease = "1",
# +        mod_revision = "184",
# +        value = "bcd",
# +        version = "1"
# +      } }
# +  },

[nic-chen]

it is better to add

[Yiyiyimu]

it is better to add

Sure I'll create another PR for this change.

[membphis]

@Yiyiyimu many thx