Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4852: Fix the bad "*uuuuu" mark in the ASF license #2207

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

aditya0yadav
Copy link
Contributor

Fix Apache License Header Formatting in Java Files
Description
This pull request addresses a minor documentation formatting issue within the Apache License headers across several Java files. Specifically, the license header contained an incorrect *uuuuu mark, which affected readability and consistency. This update ensures the license header aligns with the official Apache License format.

Changes Made

Corrected the erroneous *uuuuu entry in the license header to reflect the standard Apache License text.
Verified formatting across affected files to maintain consistency.
Files Updated

Updated four Java files under the org.apache.zookeeper.server package.
Why This Change is Needed
Ensuring the license header follows the standard format improves code readability and maintains compliance with ASF documentation standards.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aditya0yadav for taking care of this!

LGTM.

Copy link
Member

@kezhuw kezhuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some leftovers.

@kezhuw kezhuw changed the title Fix the bad "*uuuuu" mark in the ASF license ZOOKEEPER-4852: Fix the bad "*uuuuu" mark in the ASF license Oct 27, 2024
@kezhuw kezhuw merged commit 9d52264 into apache:master Oct 29, 2024
13 of 14 checks passed
kezhuw pushed a commit that referenced this pull request Oct 29, 2024
Reviewers: tisonkun, kezhuw
Author: aditya0yadav
Closes #2207 from aditya0yadav/master

(cherry picked from commit 9d52264)
kezhuw pushed a commit that referenced this pull request Oct 29, 2024
Reviewers: tisonkun, kezhuw
Author: aditya0yadav
Closes #2207 from aditya0yadav/master

(cherry picked from commit 9d52264)
@kezhuw
Copy link
Member

kezhuw commented Oct 29, 2024

Merged after applying commit suggests from my side as it is simple and affects no code.

Also, backported to branch-3.9 and branch-3.8(after conflict resolved).

@aditya0yadav Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants