Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOMEE-4443 update comparison page #1741

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

jgallimore
Copy link
Contributor

No description provided.

@rzo1 rzo1 requested a review from jungm January 10, 2025 19:39
Copy link
Member

@jungm jungm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor changes needed

github doesn't let me annotate it because it is not part of the diff (?), but there is also a title that hasn't been updated:
== [[implementations]] Implementations of Jakarta EE and MicroProfile features in TomEE 9.x

|https://jakarta.ee/specifications/transactions/2.0/[Jakarta Transactions^] (JTA) 2.0||{y}|{y}|{y}|{y}
|https://jakarta.ee/specifications/xml-binding/3.0/[Jakarta XML Binding^] (JAXB) 3.0||{y}|{y}|{y}|{y}
// MICRO PROFILE
|https://download.eclipse.org/microprofile/microprofile-5.0/microprofile-spec-5.0.html[MicroProfile specifications^] 5.0|||{y}|{y}|{y}
|https://download.eclipse.org/microprofile/microprofile-6.0/microprofile-spec-6.0.html[MicroProfile specifications^] 5.0|||{y}|{y}|{y}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text is not updated, still says MP 5

|Jakarta MVC|
https://eclipse-ee4j.github.io/krazo/[Eclipse Krazo^] {y} 2.0.x +
https://eclipse-ee4j.github.io/krazo/[Eclipse Krazo^] {y} 3.0.x +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Krazo 3.0.0 dropped CXF support (eclipse-ee4j/krazo@96a839e), we should probably not mention it anymore

@jgallimore
Copy link
Contributor Author

Thanks for the review @jungm ! I think I've managed to resolve those items and hopefully this is now ready to merge.

@rzo1 rzo1 requested a review from jungm January 16, 2025 14:46
@jungm jungm merged commit 97e4ce8 into apache:main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants