[SYNCOPE-1775] White noise: formatting + doc adjustments

apache · Sep 6, 2023 · 852b1a0 · 852b1a0
1 parent 6c5f0cb
commit 852b1a0
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 8 deletions.
diff --git a/...rc/main/java/org/apache/syncope/client/console/clientapps/ClientAppModalPanelBuilder.java b/...rc/main/java/org/apache/syncope/client/console/clientapps/ClientAppModalPanelBuilder.java
@@ -258,8 +258,8 @@ protected Iterator<String> getChoices(final String input) {
             AjaxDropDownChoicePanel<LogoutType> logoutType = new AjaxDropDownChoicePanel<>(
                     "field", "logoutType", new PropertyModel<>(clientAppTO, "logoutType"), false);
             logoutType.setChoices(List.of(LogoutType.values()));
-            fields.add(logoutType);
-            
+            fields.add(logoutType.setRequired(true));
+
             switch (type) {
                 case CASSP:
                     fields.add(new AjaxTextFieldPanel(

diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/to/ClientAppTO.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/to/ClientAppTO.java
@@ -74,7 +74,7 @@ public abstract class ClientAppTO implements NamedEntityTO {
     private String ticketExpirationPolicy;
 
     private final List<Attr> properties = new ArrayList<>();
-    
+
     private LogoutType logoutType = LogoutType.NONE;
 
     @Schema(name = "_class", requiredMode = Schema.RequiredMode.REQUIRED)

diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/types/LogoutType.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/types/LogoutType.java
@@ -22,4 +22,5 @@ public enum LogoutType {
     NONE,
     BACK_CHANNEL,
     FRONT_CHANNEL
+
 }
diff --git a/...stence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/am/ClientApp.java b/...stence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/am/ClientApp.java
@@ -86,8 +86,8 @@ public interface ClientApp extends Entity {
     List<Attr> getProperties();
 
     void setProperties(List<Attr> properties);
-    
+
     LogoutType getLogoutType();
-    
+
     void setLogoutType(LogoutType logoutType);
 }
diff --git a/...isioning-api/src/main/java/org/apache/syncope/core/provisioning/api/ConnectorManager.java b/...isioning-api/src/main/java/org/apache/syncope/core/provisioning/api/ConnectorManager.java
@@ -94,7 +94,7 @@ ConnInstance buildConnInstanceOverride(
     /**
      * Removes the Spring bean for the given resource from the context.
      *
-     * @param id Spring bean id
+     * @param resource external resource
      */
     void unregisterConnector(ExternalResource resource);
 }
diff --git a/...src/main/java/org/apache/syncope/core/provisioning/java/data/ClientAppDataBinderImpl.java b/...src/main/java/org/apache/syncope/core/provisioning/java/data/ClientAppDataBinderImpl.java
@@ -164,7 +164,6 @@ protected void copyToTO(final ClientApp clientApp, final ClientAppTO clientAppTO
         clientAppTO.setInformationUrl(clientApp.getInformationUrl());
         clientAppTO.setPrivacyUrl(clientApp.getPrivacyUrl());
         clientAppTO.setUsernameAttributeProviderConf(clientApp.getUsernameAttributeProviderConf());
-        clientAppTO.setLogoutType(clientApp.getLogoutType());
 
         clientAppTO.setAuthPolicy(Optional.ofNullable(clientApp.getAuthPolicy()).
                 map(AuthPolicy::getKey).orElse(null));
@@ -176,6 +175,7 @@ protected void copyToTO(final ClientApp clientApp, final ClientAppTO clientAppTO
                 map(TicketExpirationPolicy::getKey).orElse(null));
 
         clientAppTO.getProperties().addAll(clientApp.getProperties());
+        clientAppTO.setLogoutType(clientApp.getLogoutType());
     }
 
     protected SAML2SPClientAppTO getSAMLClientAppTO(final SAML2SPClientApp clientApp) {

diff --git a/src/main/asciidoc/reference-guide/concepts/clientapplications.adoc b/src/main/asciidoc/reference-guide/concepts/clientapplications.adoc
@@ -40,6 +40,8 @@ https://apereo.github.io/cas/6.6.x/integration/Attribute-Release-PrincipalId-Att
 . <<policies-attribute-release,attribute release policy>>
 . <<policies-ticket-expiration,ticket expiration policy>>
 . additional properties
+. logout type, mapping to
+https://apereo.github.io/cas/6.6.x/installation/Logout-Single-Signout.html#slo-requests[the equivalent CAS setting^]
 
 More parameters are required to be specified depending on the actual client application type.
 

diff --git a/wa/starter/src/main/java/org/apache/syncope/wa/starter/mapping/AbstractClientAppMapper.java b/wa/starter/src/main/java/org/apache/syncope/wa/starter/mapping/AbstractClientAppMapper.java
@@ -58,7 +58,7 @@ protected void setCommon(final BaseWebBasedRegisteredService service, final Clie
                             (existing, replacement) -> existing));
             service.setProperties(properties);
         }
-        
+
         service.setLogoutType(RegisteredServiceLogoutType.valueOf(clientApp.getLogoutType().name()));
     }