SLING-11560 - Allow configuring the IdConflictPolicy and set the default to LEGACY #61
Conversation
| @@ -324,7 +324,7 @@ | |||
| <dependency> | |||
| <groupId>org.apache.jackrabbit.vault</groupId> | |||
| <artifactId>org.apache.jackrabbit.vault</artifactId> | |||
| <version>3.4.0</version> | |||
| <version>3.6.1-T20220805092633-0b8a2641</version> | |||
There was a problem hiding this comment.
Could you depend on the latest officially released version, 3.6.0 ?
There was a problem hiding this comment.
In that version we don't have the LEGACY conflict policy.
|
I don’t think you need to maintain your own policy but rather rely on the default which should kick in whenever https://github.com/apache/jackrabbit-filevault/blob/0b8a264140b23daf474443e30117bd77a70667de/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L466 returns false in https://github.com/apache/jackrabbit-filevault/blob/4062332786a31b38866be2ebd468eeb92e204150/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L389. Please rather implement the same fallback for SCD. |
|
@kwin we'd need a configurable policy in order to gradually migrate away from the legacy mode. bq. Please rather implement the same fallback for SCD. I am confused. Do you mean that |
|
Currently getDefaultIdConflictPolicy() returns LEGACY on AEM (due to the OSGi config set for FileVault Packaging). I am not aware of any plans to change this for backwards compatibility reasons. |
No description provided.