Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Flink] Remove useless stage type. #5650

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

CheneyYin
Copy link
Contributor

@CheneyYin CheneyYin commented Oct 18, 2023

Purpose of this pull request

PR(#5483) provide CatalogTable interface. SeaTunnel row type can be inferred from CatalogTable.getSeaTunnelRowType and bypass conversion from TypeInformation. So stageType related codes(#5419 ) are useless.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Reuse exist test cases.

Check list

@CheneyYin CheneyYin marked this pull request as ready for review October 18, 2023 09:20
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CheneyYin . LGTM

@hailin0 hailin0 merged commit 4341c7c into apache:dev Oct 20, 2023
4 checks passed
@CheneyYin CheneyYin deleted the remove-flink-stage-type branch October 20, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants