Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][SeaTunnel Engine Checkpoint Storage] Checkpoint storage supports kafka compact topic #5135

Conversation

sunxiaojian
Copy link
Contributor

Purpose of this pull request

Check list

@sunxiaojian sunxiaojian force-pushed the checkpoint-storage-support-compact-topic branch 4 times, most recently from a933457 to 4ada46c Compare July 26, 2023 03:30
@sunxiaojian
Copy link
Contributor Author

@EricJoy2048 PTAL

@ic4y
Copy link
Contributor

ic4y commented Aug 2, 2023

It would be best to add an e2e test, similar to org/apache/seatunnel/engine/e2e/ClusterFaultToleranceIT.java and org.apache.seatunnel.engine.server.checkpoint.SavePointTest.

@ic4y ic4y modified the milestone: 2.3.3 Aug 2, 2023
@sunxiaojian sunxiaojian force-pushed the checkpoint-storage-support-compact-topic branch 5 times, most recently from 23db235 to 209c2ed Compare August 9, 2023 08:45
@sunxiaojian
Copy link
Contributor Author

@ic4y PTAL

@sunxiaojian sunxiaojian force-pushed the checkpoint-storage-support-compact-topic branch from 3b97d77 to 109a096 Compare August 9, 2023 09:58
@sunxiaojian
Copy link
Contributor Author

@ic4y PTAL

CI error is not related to this modification

@sunxiaojian sunxiaojian force-pushed the checkpoint-storage-support-compact-topic branch 3 times, most recently from fcf51e1 to 8d46847 Compare August 10, 2023 09:12
@ic4y
Copy link
Contributor

ic4y commented Aug 10, 2023

image @wu-a-ge Please take a look at this.

@sunxiaojian sunxiaojian force-pushed the checkpoint-storage-support-compact-topic branch from 8d46847 to 46a2dcf Compare August 11, 2023 02:04
@sunxiaojian
Copy link
Contributor Author

image @wu-a-ge Please take a look at this.

@ic4y done

@sunxiaojian sunxiaojian force-pushed the checkpoint-storage-support-compact-topic branch from 78b3436 to dc090f1 Compare August 14, 2023 11:38
@sunxiaojian sunxiaojian deleted the checkpoint-storage-support-compact-topic branch September 6, 2023 04:19
@sunxiaojian sunxiaojian restored the checkpoint-storage-support-compact-topic branch January 8, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants