[feature][jdbc] Jdbc database support identifier #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Jul 15, 2023
|
|
||
| Option<String> FIELD_IDE = | ||
| Options.key("field_ide") | ||
| .stringType() |
There was a problem hiding this comment.
We support enum type, please use it.
| } | ||
|
|
||
| @Override | ||
| public String quoteIdentifier(String identifier) { |
There was a problem hiding this comment.
Please add test case for this new feature.
There was a problem hiding this comment.
Done! e2e has been added
TaoZex
reviewed
Jul 19, 2023
|
Related documents need to be updated |
Done ! |
Done！ |
XiaoJiang521
force-pushed
the
dev-jdbc-identifier
branch
from
3743fe1
to
d85bd63
Compare
chl-wxp
approved these changes
Sep 11, 2023
EricJoy2048
approved these changes
Sep 11, 2023
hailin0
reviewed
Sep 11, 2023
...or-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java
Show resolved
Hide resolved
...rg/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dialectenum/FieldIdeEnum.java
Show resolved
Hide resolved
Hisoka-X
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
release-note.