Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][Connector-V2][cdc] Support flink running cdc job #4918

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

Carl-Zhou-CN
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN commented Jun 14, 2023

Purpose of this pull request

close #4605

Check list

@hailin0
Copy link
Member

hailin0 commented Jun 14, 2023

good

@TyrantLucifer
Copy link
Member

good pr

@EricJoy2048
Copy link
Member

niubility!

@hailin0
Copy link
Member

hailin0 commented Jul 9, 2023

waitting for ci check

@Carl-Zhou-CN
Copy link
Member Author

@hailin0 Please help to start the client,the mysql cdc driver is abnormal

@Carl-Zhou-CN
Copy link
Member Author

image
Appears to be a zeta startup exception

@hailin0
Copy link
Member

hailin0 commented Jul 10, 2023

@EricJoy2048

@Carl-Zhou-CN
Copy link
Member Author

@evan766 Can you share your json configuration?

@Carl-Zhou-CN
Copy link
Member Author

Carl-Zhou-CN commented Jul 12, 2023

image
Whether this was removed when merged?@evan766

@Carl-Zhou-CN
Copy link
Member Author

@evan766 Can I add my wechat zy330600

@liugddx liugddx closed this Jul 18, 2023
@liugddx liugddx reopened this Jul 18, 2023
@hailin0
Copy link
Member

hailin0 commented Jul 25, 2023

Please merge dev branch into this pr

@Carl-Zhou-CN

@Carl-Zhou-CN
Copy link
Member Author

@hailin0 ok

@hailin0 hailin0 closed this Jul 27, 2023
@hailin0 hailin0 reopened this Jul 27, 2023
@@ -65,7 +65,7 @@
@Slf4j
@DisabledOnContainer(
value = {},
type = {EngineType.SPARK, EngineType.FLINK},
type = {EngineType.SPARK},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hailin0
Copy link
Member

hailin0 commented Jul 28, 2023

check ci error

@EricJoy2048 EricJoy2048 added this to the 2.3.3 milestone Aug 4, 2023
@ic4y ic4y removed this from the 2.3.3 milestone Aug 6, 2023
@Carl-Zhou-CN
Copy link
Member Author

Temporarily blocks mongo cdc effects #5251

@Carl-Zhou-CN
Copy link
Member Author

image
In his own warehouse he was successful

@hailin0 hailin0 added this to the 2.3.4 milestone Aug 23, 2023
@Carl-Zhou-CN
Copy link
Member Author

@ic4y @hailin0 @EricJoy2048 @Hisoka-X @TyrantLucifer Please help review, thank you

@hailin0
Copy link
Member

hailin0 commented Sep 12, 2023

LGTM

Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@TyrantLucifer TyrantLucifer merged commit 5e37883 into apache:dev Sep 12, 2023
54 checks passed
Comment on lines +95 to +109
if (pluginConfig.hasPath(SOURCE_TABLE_NAME)) {
String sourceTable = pluginConfig.getString(SOURCE_TABLE_NAME);
flinkRuntimeEnvironment.registerResultTable(
pluginConfig,
dataStream,
resultTable,
isAppendMap.getOrDefault(sourceTable, true));
registerAppendStream(pluginConfig);
return;
}
flinkRuntimeEnvironment.registerResultTable(
pluginConfig,
dataStream,
resultTable,
isAppendMap.getOrDefault(resultTable, true));
Copy link
Member

@Hisoka-X Hisoka-X Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Carl-Zhou-CN , could you explain for me why we should register table as source table name when both have RESULT_TABLE_NAME and SOURCE_TABLE_NAME? Thanks.

I got it. Please ignore it.

gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
* [feature][Connector-V2][cdc] Support flink running cdc job

* [feature][Connector-V2][cdc] Support flink running cdc job

* [feature][Connector-V2][cdc] mongo e2e delete

---------

Co-authored-by: zhouyao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][CDC] Support flink running cdc job
7 participants