Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc][Sqlserver]Add notice into Sqlserver cdc doc #4721

Closed

Conversation

zhangchengming601
Copy link
Contributor

Purpose of this pull request

Check list

docs/en/connector-v2/sink/SQLServer.md Show resolved Hide resolved
docs/en/connector-v2/sink/SQLServer.md Outdated Show resolved Hide resolved
Write data through jdbc. Support Batch mode and Streaming mode, support concurrent writing, support exactly-once
semantics (using XA transaction guarantee).

## Supported DataSource list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird, SQLServer sink only support SQLServer, why use Supported DataSource list?

docs/en/connector-v2/sink/SQLServer.md Show resolved Hide resolved
docs/en/connector-v2/sink/SQLServer.md Show resolved Hide resolved
docs/en/connector-v2/sink/SQLServer.md Show resolved Hide resolved
docs/en/connector-v2/sink/redshift.md Show resolved Hide resolved
@Hisoka-X
Copy link
Member

Hisoka-X commented May 8, 2023

Each doc have same problems, please fix it. Thansk.

@zhilinli123
Copy link
Contributor

Please close duplicate pull requests @zhangchengming601
I added some review comments in this community boss help to open up :#4715

docs/en/connector-v2/sink/SQLServer.md Outdated Show resolved Hide resolved
docs/en/connector-v2/sink/SQLServer.md Outdated Show resolved Hide resolved
docs/en/connector-v2/sink/redshift.md Outdated Show resolved Hide resolved
docs/en/connector-v2/sink/redshift.md Outdated Show resolved Hide resolved
docs/en/connector-v2/source/SQLServer.md Outdated Show resolved Hide resolved
docs/en/connector-v2/source/redshift.md Show resolved Hide resolved
docs/en/connector-v2/source/redshift.md Outdated Show resolved Hide resolved
docs/en/connector-v2/source/SQLServer.md Outdated Show resolved Hide resolved
docs/en/connector-v2/source/SQLServer.md Outdated Show resolved Hide resolved
docs/en/connector-v2/source/SQLServer.md Outdated Show resolved Hide resolved
@@ -167,6 +167,35 @@ source {

Source plugin common parameters, please refer to [Source Common Options](common-options.md) for details.

## notice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think update this doc to the new format is better.

@TyrantLucifer
Copy link
Member

fix ci error

image

@EricJoy2048 EricJoy2048 reopened this Sep 11, 2023
| DATETIME<br />DATETIME2<br />SMALLDATETIME<br />DATETIMEOFFSET | LOCAL_DATE_TIME |
| TIMESTAMP<br />BINARY<br />VARBINARY<br />IMAGE<br />UNKNOWN | Not supported yet |

## Options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sink Options

Comment on lines +54 to +55
| name | type | required | default | Description |
|------------------------------|--------|----------|-----------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| Name | Type | Required | Default | Description|

Comment on lines +95 to +96
name = "string"
age = "int"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add SqlSerber so type testing is sure to work

max_retries = 0
user = "root"
password = "123456"
query = "insert into test_table(name,age) values(?,?)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment on lines +93 to +94
name = "string"
age = "int"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment on lines +52 to +53
| name | type | required | default | description |
|------------------------------|--------|----------|-----------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

| TIMESTAMP<br />TIMESTAMP_WITH_OUT_TIME_ZONE<br />TIMESTAMPTZ | LOCALDATETIME |
| GEOMETRY | Not supported yet |

## Options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source Options

| TIMESTAMP<br />TIMESTAMP_WITH_OUT_TIME_ZONE<br />TIMESTAMPTZ | LOCALDATETIME |
| GEOMETRY | Not supported yet |

## Options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source Options


## Options

| name | type | required | default | description |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@EricJoy2048
Copy link
Member

@zhilinli123 Please fix ci error.

@zhilinli123
Copy link
Contributor

@zhilinli123 Please fix ci error.

To replace the current pr links to #5498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants