[Fix][Connector-V2] Fix hana type loss of precision (#7912)

apache · Oct 26, 2024 · 18dcca3 · 18dcca3
1 parent ba7fa23
commit 18dcca3
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/...he/seatunnel/connectors/seatunnel/jdbc/internal/dialect/saphana/SapHanaTypeConverter.java b/...he/seatunnel/connectors/seatunnel/jdbc/internal/dialect/saphana/SapHanaTypeConverter.java
@@ -297,6 +297,7 @@ public Column convert(BasicTypeDefine typeDefine) {
                 break;
             case HANA_ST_POINT:
             case HANA_ST_GEOMETRY:
+                builder.columnLength(typeDefine.getLength());
                 builder.dataType(PrimitiveByteArrayType.INSTANCE);
                 break;
             default:

diff --git a/...eatunnel/connectors/seatunnel/jdbc/internal/dialect/saphana/SapHanaTypeConverterTest.java b/...eatunnel/connectors/seatunnel/jdbc/internal/dialect/saphana/SapHanaTypeConverterTest.java
@@ -382,6 +382,37 @@ public void testConvertDatetime() {
         Assertions.assertEquals(typeDefine.getColumnType(), column.getSourceType());
     }
 
+    @Test
+    public void testConvertSpecialType() {
+        BasicTypeDefine<Object> typeDefine =
+                BasicTypeDefine.builder()
+                        .name("test")
+                        .columnType("ST_POINT")
+                        .length(8L)
+                        .dataType("ST_POINT")
+                        .build();
+        Column column = SapHanaTypeConverter.INSTANCE.convert(typeDefine);
+
+        Assertions.assertEquals(typeDefine.getName(), column.getName());
+        Assertions.assertEquals(PrimitiveByteArrayType.INSTANCE, column.getDataType());
+        Assertions.assertEquals(8, column.getColumnLength());
+        Assertions.assertEquals(typeDefine.getColumnType(), column.getSourceType());
+
+        typeDefine =
+                BasicTypeDefine.builder()
+                        .name("test")
+                        .columnType("ST_GEOMETRY")
+                        .length(8L)
+                        .dataType("ST_GEOMETRY")
+                        .build();
+        column = SapHanaTypeConverter.INSTANCE.convert(typeDefine);
+
+        Assertions.assertEquals(typeDefine.getName(), column.getName());
+        Assertions.assertEquals(PrimitiveByteArrayType.INSTANCE, column.getDataType());
+        Assertions.assertEquals(8, column.getColumnLength());
+        Assertions.assertEquals(typeDefine.getColumnType(), column.getSourceType());
+    }
+
     @Test
     public void testReconvertUnsupported() {
         Column column =