Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS processing order matters #154

Open
carlosrovira opened this issue Jun 18, 2020 · 0 comments
Open

CSS processing order matters #154

carlosrovira opened this issue Jun 18, 2020 · 0 comments

Comments

@carlosrovira
Copy link
Contributor

carlosrovira commented Jun 18, 2020

Hi,

while doing Jewel SimpleLoader component I discover the following css rule:

.jewel.loader {
    border: 16px solid #f3f3f3
    border-radius: 50%
    border-top: 16px solid #3498db
}

doesn't work as expected. The "border-top" is output before "border" and this make it border takes precedence, while if we left the current order, the browser finds first border and then border-top so making the border top blue instead of grey.

Workaround for now is:

.jewel.loader {
    border: 16px solid #f3f3f3
    border-radius: 50%
}
.jewel.loader.segment {
        border-top: 16px solid #3498db
}

butis very limiting and cumbersome.

I think we're doing some kind of rule ordering while processing, since no matter how I define the CSS, I get always the same order. I think we should prevent any ordering to avoid this kind of problems that are valid CSS and becomes invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant