Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ErrorController.getErrorPath() #562

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

bpereto
Copy link
Contributor

@bpereto bpereto commented Apr 30, 2024

Fixes #560

Motivation

Workaround to fix error with spring boot 2.5

Modifications

No ErrorController is used, thus exclude it to prevent zuul accessing it.
the zuul implementation should be replaced sepparately.

Verifying this change

  • Make sure that the change passes the ./gradlew build checks.

@hezhangjian
Copy link
Member

I don't know if we should merge this. It might be other problems in zuul and springboot 2.5. What did we do with zuul? Can we replace it?

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit 3243fea into apache:master May 3, 2024
1 check passed
@liangyepianzhou liangyepianzhou added this to the 0.4.0 milestone Jan 10, 2025
liangyepianzhou pushed a commit that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants