fix init_db.sql to also take variables from environment #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
reviewed
Apr 3, 2024
Co-authored-by: Lari Hotari <[email protected]>
1 task
liangyepianzhou
pushed a commit
that referenced
this pull request
Jan 12, 2025
* fix init_db.sql to also take variables from environment * make other occurrences of username dynamic * Update docker/init_db.sql Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 3e5430c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The init script inside the docker container did not depend on the environment variables that were set in the backend (USERNAME / PASSWORD). This can lead to problems when trying to connect to the database and expecting the same credentials as set in the environment.
No errors where visible because postgre "trusts" connections from localhost by default, hence the backend did not have to authenticate / was allowed to authenticate incorrectly.
Modifications
The first SQL command to alter the role is made dependent on the environment variables.
Verifying this change
./gradlew buildchecks. (they are not part of these checks I assume)