Skip to content

Commit

Permalink
Fix GHA workflow syntax (#511)
Browse files Browse the repository at this point in the history
Signed-off-by: tison <[email protected]>
  • Loading branch information
tisonkun authored Mar 20, 2023
1 parent 482ec65 commit e036664
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 42 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,18 @@ name: Java CI
on:
push:
branches: [master]
pull_request: [master]
pull_request:
branches: [master]

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up JDK 1.8
- name: Set up JDK 8
uses: actions/setup-java@v3
with:
java-version: 1.8
java-version: 8
distribution: temurin
- name: Build with Gradle
run: ./gradlew build
64 changes: 28 additions & 36 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,40 +10,35 @@ Before committing code changes to Apache Pulsar Manager, you need to install req

If you have not installed Java and Node, follow the instructions below.

Dependency | Installation guide
|---|---
Java 8 | https://openjdk.java.net/install/
Node 10.15 | https://nodejs.org/en/
| Dependency | Installation guide |
| ---------- | --------------------------------- |
| Java 8 | https://openjdk.java.net/install/ |
| Node 10.15 | https://nodejs.org/en/ |

### Fork pulsar-manager repository

Fork the [pulsar-manager](https://github.com/apache/pulsar-manager) repository to your GitHub repository.

### Install pulsar-manager dependency
### Install pulsar-manager dependency

1. Clone pulsar-manager code to your machine.

```bash
$ git clone [email protected]:[your-github-id]/pulsar-manager.git
git clone [email protected]:[your-github-id]/pulsar-manager.git
```

2. Install pulsar-manger dependencies.

```bash
$ cd pulsar-manager
$ ./gradlew build -x test

$ cd front-end
$ npm install --save
```bash
cd pulsar-manager
./gradlew build -x test
```

## Configure IDE
## Configure IDE

Apache Pulsar Manager uses [lombok](https://projectlombok.org/), so set up your IDE with the required plugins.

### Configure Intellij
### Configure Intellij

To configure annotation processing in IntelliJ, follow the steps below.

Expand All @@ -60,35 +55,32 @@ Follow the instructions [here](https://howtodoinjava.com/automation/lombok-eclip
## Contribution workflow

1. Add a remote repository.

```bash
$ git remote add apache [email protected]:apache/pulsar-manager.git
git remote add apache [email protected]:apache/pulsar-manager.git
```

2. Sync you local repository with the remote repository.

```bash
$ git checkout master
$ git pull apache master
git checkout master
git pull apache master
```

3. Create your PR and commit code changes.

```bash
$ git checkout -b your_branch
$ git add [your change files]
$ git commit -m "commit messages"
$ git push origin your_branch
git checkout -b your_branch
git add [your change files]
git commit -m "commit messages"
git push origin your_branch
```

> #### Note
>
> Apache Pulsar Manager uses the open-source protocol of Apache License 2.0.
> **Note**
>
> Pulsar Manager is released under Apache License 2.0.
>
> If you commit code changes with new files, run the following command to add the license at the beginning of each file.
> If you commit new files, run the following command to add the license header for each file:
>
> ```bash
> ./gradlew licenseFormat
Expand All @@ -100,8 +92,8 @@ Follow the code styles below to keep code consistent and easy to maintain.

Make sure your code looks plain and simple.

Language | Code style guide
|---|---
Java | https://google.github.io/styleguide/javaguide.html
Vue | https://vuejs.org/v2/style-guide/
| Language | Code style guide |
| -------- | -------------------------------------------------- |
| Java | https://google.github.io/styleguide/javaguide.html |
| Vue | https://vuejs.org/v2/style-guide/ |

3 changes: 1 addition & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ buildscript {
}

plugins {
id "com.github.hierynomus.license" version "0.14.0"
id "com.moowork.node" version "1.1.0"
id "com.github.hierynomus.license" version "0.16.1"
id "java"
id "eclipse"
id "idea"
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ hibernateValidatorVersion=6.0.13.Final
jsonWebTokenVersion=0.9.0
jsonWebTokenApiVersion=0.10.5
jsonWebTokenImplVersion=0.10.5
lombokVersion=1.18.10
lombokVersion=1.18.26
pageHelperVersion=1.2.4
mockitoVersion=2.8.47
guavaVersion=21.0
Expand Down

0 comments on commit e036664

Please sign in to comment.