Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Support endpoints field in the config endpoint #383

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danielhumanmod
Copy link

@danielhumanmod danielhumanmod commented Oct 17, 2024

Description

As the endpoints field was introduced in Iceberg REST spec recently to describe the server capabilities in /v1/config, Polaris can align with this change by extending the catalog config API to include the endpoints field.

Fixes #316

Included Changes:

  • Update rest-catalog-open-api.yaml config
  • Add endpoints support in IcebergCatalogAdapter
  • Extend ConfigResponse and ResourcePaths as a temp workaround before integrated with Iceberg 1.70

TODO
Since the latest changes related to endpoints are not yet released (currently at version 1.6.1) and are planned for release in 1.7.0, we need to replace the two extended classes with the Iceberg's implementations after the upgrade.
Related PR: apache/iceberg#10929

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

import org.apache.iceberg.rest.responses.ConfigResponse;

// TODO: Replace with Iceberg's ConfigResponse after integrating Iceberg 1.7.0
// Related PR: https://github.com/apache/iceberg/pull/10929#issuecomment-2418591566
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to hold off until 1.7.0?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we will hold if off until 17.0 based on the discussion here: #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Support endpoints field in the config endpoint
2 participants