Enable errorprone PatternMatchingInstanceof (#393)

apache · Oct 22, 2024 · 6850881 · 6850881
1 parent 734ecd4
commit 6850881
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/build-logic/src/main/kotlin/polaris-java.gradle.kts b/build-logic/src/main/kotlin/polaris-java.gradle.kts
@@ -44,6 +44,7 @@ tasks.withType(JavaCompile::class.java).configureEach {
     "MissingOverride",
     "ModifiedButNotUsed",
     "OrphanedFormatString",
+    "PatternMatchingInstanceof",
     "StringCaseLocaleUsage",
   )
 }

diff --git a/...ce/src/test/java/org/apache/polaris/service/catalog/PolarisPassthroughResolutionView.java b/...ce/src/test/java/org/apache/polaris/service/catalog/PolarisPassthroughResolutionView.java
@@ -69,8 +69,7 @@ public PolarisResolvedPathWrapper getResolvedPath(Object key) {
     PolarisResolutionManifest manifest =
         entityManager.prepareResolutionManifest(callContext, authenticatedPrincipal, catalogName);
 
-    if (key instanceof Namespace) {
-      Namespace namespace = (Namespace) key;
+    if (key instanceof Namespace namespace) {
       manifest.addPath(
           new ResolverPath(Arrays.asList(namespace.levels()), PolarisEntityType.NAMESPACE),
           namespace);
@@ -88,8 +87,7 @@ public PolarisResolvedPathWrapper getResolvedPath(Object key, PolarisEntitySubTy
     PolarisResolutionManifest manifest =
         entityManager.prepareResolutionManifest(callContext, authenticatedPrincipal, catalogName);
 
-    if (key instanceof TableIdentifier) {
-      TableIdentifier identifier = (TableIdentifier) key;
+    if (key instanceof TableIdentifier identifier) {
       manifest.addPath(
           new ResolverPath(
               PolarisCatalogHelpers.tableIdentifierToList(identifier),
@@ -110,8 +108,7 @@ public PolarisResolvedPathWrapper getPassthroughResolvedPath(Object key) {
     PolarisResolutionManifest manifest =
         entityManager.prepareResolutionManifest(callContext, authenticatedPrincipal, catalogName);
 
-    if (key instanceof Namespace) {
-      Namespace namespace = (Namespace) key;
+    if (key instanceof Namespace namespace) {
       manifest.addPassthroughPath(
           new ResolverPath(Arrays.asList(namespace.levels()), PolarisEntityType.NAMESPACE),
           namespace);
@@ -129,8 +126,7 @@ public PolarisResolvedPathWrapper getPassthroughResolvedPath(
     PolarisResolutionManifest manifest =
         entityManager.prepareResolutionManifest(callContext, authenticatedPrincipal, catalogName);
 
-    if (key instanceof TableIdentifier) {
-      TableIdentifier identifier = (TableIdentifier) key;
+    if (key instanceof TableIdentifier identifier) {
       manifest.addPassthroughPath(
           new ResolverPath(
               PolarisCatalogHelpers.tableIdentifierToList(identifier),