Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for copy file with subdirectories for ADLSGen2PinotFS #14860

Conversation

aishikbh
Copy link
Contributor

@aishikbh aishikbh commented Jan 22, 2025

Issue

Currently if the source has a file buried under multiple subdirectories, then the copyToLocalFile method fails because it does not recreate the parent directories locally.

Fix

Create the parent directories for the file locally if they exist.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.77%. Comparing base (59551e4) to head (6113cb6).
Report is 1605 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14860      +/-   ##
============================================
+ Coverage     61.75%   63.77%   +2.02%     
- Complexity      207     1469    +1262     
============================================
  Files          2436     2708     +272     
  Lines        133233   151316   +18083     
  Branches      20636    23358    +2722     
============================================
+ Hits          82274    96501   +14227     
- Misses        44911    47568    +2657     
- Partials       6048     7247    +1199     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.73% <ø> (+2.02%) ⬆️
java-21 63.64% <ø> (+2.01%) ⬆️
skip-bytebuffers-false 63.76% <ø> (+2.02%) ⬆️
skip-bytebuffers-true 63.61% <ø> (+35.88%) ⬆️
temurin 63.77% <ø> (+2.02%) ⬆️
unittests 63.77% <ø> (+2.02%) ⬆️
unittests1 56.33% <ø> (+9.44%) ⬆️
unittests2 34.05% <ø> (+6.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swaminathanmanish swaminathanmanish merged commit 1e21ffe into apache:master Jan 22, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants