Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the merge rollup task capabilities #14355

Conversation

davecromberge
Copy link
Member

Merge rollup task feature enhancement

Adds the capability to erase dimension values from a merged segment before rollup to reduce cardinality and increase the degree to which common dimension coordinates are aggregated. This can result in a space saving for some dimensions which are not important in historic data.

See: #14310

release-notes:

  • New configuration options

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.87%. Comparing base (59551e4) to head (da8fa71).
Report is 1383 commits behind head on master.

Files with missing lines Patch % Lines
...n/tasks/mergerollup/DimensionValueTransformer.java 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14355      +/-   ##
============================================
+ Coverage     61.75%   63.87%   +2.12%     
- Complexity      207     1580    +1373     
============================================
  Files          2436     2674     +238     
  Lines        133233   146819   +13586     
  Branches      20636    22515    +1879     
============================================
+ Hits          82274    93783   +11509     
- Misses        44911    46105    +1194     
- Partials       6048     6931     +883     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.84% <91.17%> (+2.13%) ⬆️
java-21 63.75% <91.17%> (+2.12%) ⬆️
skip-bytebuffers-false 63.85% <91.17%> (+2.10%) ⬆️
skip-bytebuffers-true 63.72% <91.17%> (+36.00%) ⬆️
temurin 63.87% <91.17%> (+2.12%) ⬆️
unittests 63.87% <91.17%> (+2.12%) ⬆️
unittests1 55.53% <ø> (+8.64%) ⬆️
unittests2 34.59% <91.17%> (+6.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@davecromberge davecromberge force-pushed the feature/extend-merge-rollup-capabilities-1 branch from 77b3e0e to b604850 Compare November 1, 2024 10:29
@Jackie-Jiang Jackie-Jiang added enhancement release-notes Referenced by PRs that need attention when compiling the next release notes Configuration Config changes (addition/deletion/change in behavior) ingestion minion labels Nov 17, 2024
@swaminathanmanish
Copy link
Contributor

Taking a look @davecromberge

Adds the capability to erase dimension values from a merged segment
before rollup to reduce cardinality and increase the degree to which
common dimension coordinates are aggregated.  This can result in a
space saving for some dimensions which are not important in historic
data.

See: apache#14310
@davecromberge davecromberge force-pushed the feature/extend-merge-rollup-capabilities-1 branch from 909967d to da8fa71 Compare November 22, 2024 12:45
@Jackie-Jiang Jackie-Jiang merged commit ed1de92 into apache:master Dec 3, 2024
21 checks passed
davecromberge added a commit to davecromberge/pinot-docs that referenced this pull request Jan 17, 2025
- apache/pinot#14355
- apache/pinot#14373
- apache/pinot#14625

Documents configuration introduced in aforementioned pull requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Config changes (addition/deletion/change in behavior) enhancement ingestion minion release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants