Make TableSizeReader and StorageQuotaChecker available as service #13560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shounakmk219
force-pushed
the
storage-quota-checker-refactor
branch
from
ab7b402 to
c883e3e
Compare
shounakmk219
force-pushed
the
storage-quota-checker-refactor
branch
from
9ddfa3b to
af7ab43
Compare
shounakmk219
commented
Jul 8, 2024
| super("SegmentStatusChecker", config.getStatusCheckerFrequencyInSeconds(), | ||
| config.getStatusCheckerInitialDelayInSeconds(), pinotHelixResourceManager, leadControllerManager, | ||
| controllerMetrics); | ||
|
|
||
| _waitForPushTimeSeconds = config.getStatusCheckerWaitForPushTimeInSeconds(); | ||
| _tableSizeReader = | ||
| new TableSizeReader(executorService, new PoolingHttpClientConnectionManager(), _controllerMetrics, |
There was a problem hiding this comment.
Is it ok to use the shared connectionManager here?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13560 +/- ##
============================================
+ Coverage 61.75% 62.01% +0.26%
+ Complexity 207 198 -9
============================================
Files 2436 2558 +122
Lines 133233 140903 +7670
Branches 20636 21864 +1228
============================================
+ Hits 82274 87382 +5108
- Misses 44911 46889 +1978
- Partials 6048 6632 +584
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
TableSizeReaderandStorageQuotaCheckeravailable as service to avoid passing multiple services across code