Remove call to deprecated ArrayUtils.isEquals #13551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13551 +/- ##
============================================
+ Coverage 61.75% 62.06% +0.31%
+ Complexity 207 198 -9
============================================
Files 2436 2558 +122
Lines 133233 140895 +7662
Branches 20636 21857 +1221
============================================
+ Hits 82274 87446 +5172
- Misses 44911 46810 +1899
- Partials 6048 6639 +591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
reviewed
Jul 8, 2024
| @@ -89,7 +89,7 @@ public static ForwardIndexReader createIndexReader(PinotDataBuffer dataBuffer, C | |||
| if (dataBuffer.size() >= CLPForwardIndexCreatorV1.MAGIC_BYTES.length) { | |||
| byte[] magicBytes = new byte[CLPForwardIndexCreatorV1.MAGIC_BYTES.length]; | |||
| dataBuffer.copyTo(0, magicBytes); | |||
| if (ArrayUtils.isEquals(magicBytes, CLPForwardIndexCreatorV1.MAGIC_BYTES)) { | |||
| if (Objects.deepEquals(magicBytes, CLPForwardIndexCreatorV1.MAGIC_BYTES)) { | |||
There was a problem hiding this comment.
I guess you want to use Arrays.equals()
Jackie-Jiang
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels
cleanupDescription