Add nonLeaderCleanUp with tables parameters in PinotTaskGenerator #13509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
Jul 3, 2024
Jackie-Jiang
reviewed
Jul 3, 2024
...controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
Outdated
Show resolved
Hide resolved
jackjlli
force-pushed
the
add-signiture-to-clean-up-tasks
branch
from
632e155 to
03d68d7
Compare
jackjlli
force-pushed
the
add-signiture-to-clean-up-tasks
branch
from
03d68d7 to
48dfc0d
Compare
jackjlli
added a commit
that referenced
this pull request
Jul 18, 2024
jackjlli
added a commit
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the nonLeaderCleanUp method with the list of table names as the parameter in the PinotTaskGenerator interface.
When the tasks are scheduled, the current controller may not always be the lead controller for the tables that were assigned to this controller (e.g. due to hardware uplift, downlift, maintenance), so there might be stale information like metrics that are left in this controller. Adding the
nonLeaderCleanupoverride method inPinotTaskGeneratorhelps clean up the stale information.