-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Multi-stage] Allow filter for lookup JOIN (#14523)
- Loading branch information
1 parent
0027de5
commit 38abc64
Showing
7 changed files
with
425 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
262 changes: 262 additions & 0 deletions
262
...t-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotFilterJoinRule.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,262 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pinot.calcite.rel.rules; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import com.google.common.collect.Sets; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import org.apache.calcite.plan.RelOptRuleCall; | ||
| import org.apache.calcite.plan.RelOptUtil; | ||
| import org.apache.calcite.rel.RelNode; | ||
| import org.apache.calcite.rel.core.Filter; | ||
| import org.apache.calcite.rel.core.Join; | ||
| import org.apache.calcite.rel.core.JoinRelType; | ||
| import org.apache.calcite.rel.rules.FilterJoinRule; | ||
| import org.apache.calcite.rel.rules.FilterJoinRule.FilterIntoJoinRule.FilterIntoJoinRuleConfig; | ||
| import org.apache.calcite.rel.rules.FilterJoinRule.JoinConditionPushRule.JoinConditionPushRuleConfig; | ||
| import org.apache.calcite.rel.type.RelDataType; | ||
| import org.apache.calcite.rex.RexBuilder; | ||
| import org.apache.calcite.rex.RexCall; | ||
| import org.apache.calcite.rex.RexNode; | ||
| import org.apache.calcite.rex.RexUtil; | ||
| import org.apache.calcite.tools.RelBuilder; | ||
| import org.apache.pinot.calcite.rel.hint.PinotHintOptions; | ||
| import org.checkerframework.checker.nullness.qual.Nullable; | ||
|
|
||
|
|
||
| /** | ||
| * Similar to {@link FilterJoinRule} but do not push down filter into right side of lookup join. | ||
| */ | ||
| public abstract class PinotFilterJoinRule<C extends FilterJoinRule.Config> extends FilterJoinRule<C> { | ||
|
|
||
| private PinotFilterJoinRule(C config) { | ||
| super(config); | ||
| } | ||
|
|
||
| // Following code are copy-pasted from Calcite, and modified to not push down filter into right side of lookup join. | ||
| //@formatter:off | ||
| @Override | ||
| protected void perform(RelOptRuleCall call, @Nullable Filter filter, Join join) { | ||
| List<RexNode> joinFilters = | ||
| RelOptUtil.conjunctions(join.getCondition()); | ||
| final List<RexNode> origJoinFilters = ImmutableList.copyOf(joinFilters); | ||
|
|
||
| // If there is only the joinRel, | ||
| // make sure it does not match a cartesian product joinRel | ||
| // (with "true" condition), otherwise this rule will be applied | ||
| // again on the new cartesian product joinRel. | ||
| if (filter == null && joinFilters.isEmpty()) { | ||
| return; | ||
| } | ||
|
|
||
| final List<RexNode> aboveFilters = | ||
| filter != null | ||
| ? getConjunctions(filter) | ||
| : new ArrayList<>(); | ||
| final ImmutableList<RexNode> origAboveFilters = | ||
| ImmutableList.copyOf(aboveFilters); | ||
|
|
||
| // Simplify Outer Joins | ||
| JoinRelType joinType = join.getJoinType(); | ||
| if (config.isSmart() | ||
| && !origAboveFilters.isEmpty() | ||
| && join.getJoinType() != JoinRelType.INNER) { | ||
| joinType = RelOptUtil.simplifyJoin(join, origAboveFilters, joinType); | ||
| } | ||
|
|
||
| final List<RexNode> leftFilters = new ArrayList<>(); | ||
| final List<RexNode> rightFilters = new ArrayList<>(); | ||
|
|
||
| // TODO - add logic to derive additional filters. E.g., from | ||
| // (t1.a = 1 AND t2.a = 2) OR (t1.b = 3 AND t2.b = 4), you can | ||
| // derive table filters: | ||
| // (t1.a = 1 OR t1.b = 3) | ||
| // (t2.a = 2 OR t2.b = 4) | ||
|
|
||
| // PINOT MODIFICATION to not push down filter into right side of lookup join. | ||
| boolean canPushRight = !PinotHintOptions.JoinHintOptions.useLookupJoinStrategy(join); | ||
|
|
||
| // Try to push down above filters. These are typically where clause | ||
| // filters. They can be pushed down if they are not on the NULL | ||
| // generating side. | ||
| boolean filterPushed = | ||
| RelOptUtil.classifyFilters(join, | ||
| aboveFilters, | ||
| joinType.canPushIntoFromAbove(), | ||
| joinType.canPushLeftFromAbove(), | ||
| canPushRight && joinType.canPushRightFromAbove(), | ||
| joinFilters, | ||
| leftFilters, | ||
| rightFilters); | ||
|
|
||
| // Move join filters up if needed | ||
| validateJoinFilters(aboveFilters, joinFilters, join, joinType); | ||
|
|
||
| // If no filter got pushed after validate, reset filterPushed flag | ||
| if (leftFilters.isEmpty() | ||
| && rightFilters.isEmpty() | ||
| && joinFilters.size() == origJoinFilters.size() | ||
| && aboveFilters.size() == origAboveFilters.size()) { | ||
| if (Sets.newHashSet(joinFilters) | ||
| .equals(Sets.newHashSet(origJoinFilters))) { | ||
| filterPushed = false; | ||
| } | ||
| } | ||
|
|
||
| if (joinType != JoinRelType.FULL) { | ||
| joinFilters = inferJoinEqualConditions(joinFilters, join); | ||
| } | ||
|
|
||
| // Try to push down filters in ON clause. A ON clause filter can only be | ||
| // pushed down if it does not affect the non-matching set, i.e. it is | ||
| // not on the side which is preserved. | ||
|
|
||
| // Anti-join on conditions can not be pushed into left or right, e.g. for plan: | ||
| // | ||
| // Join(condition=[AND(cond1, $2)], joinType=[anti]) | ||
| // : - prj(f0=[$0], f1=[$1], f2=[$2]) | ||
| // : - prj(f0=[$0]) | ||
| // | ||
| // The semantic would change if join condition $2 is pushed into left, | ||
| // that is, the result set may be smaller. The right can not be pushed | ||
| // into for the same reason. | ||
| if (RelOptUtil.classifyFilters( | ||
| join, | ||
| joinFilters, | ||
| false, | ||
| joinType.canPushLeftFromWithin(), | ||
| canPushRight && joinType.canPushRightFromWithin(), | ||
| joinFilters, | ||
| leftFilters, | ||
| rightFilters)) { | ||
| filterPushed = true; | ||
| } | ||
|
|
||
| // if nothing actually got pushed and there is nothing leftover, | ||
| // then this rule is a no-op | ||
| if ((!filterPushed | ||
| && joinType == join.getJoinType()) | ||
| || (joinFilters.isEmpty() | ||
| && leftFilters.isEmpty() | ||
| && rightFilters.isEmpty())) { | ||
| return; | ||
| } | ||
|
|
||
| // create Filters on top of the children if any filters were | ||
| // pushed to them | ||
| final RexBuilder rexBuilder = join.getCluster().getRexBuilder(); | ||
| final RelBuilder relBuilder = call.builder(); | ||
| final RelNode leftRel = | ||
| relBuilder.push(join.getLeft()).filter(leftFilters).build(); | ||
| final RelNode rightRel = | ||
| relBuilder.push(join.getRight()).filter(rightFilters).build(); | ||
|
|
||
| // create the new join node referencing the new children and | ||
| // containing its new join filters (if there are any) | ||
| final ImmutableList<RelDataType> fieldTypes = | ||
| ImmutableList.<RelDataType>builder() | ||
| .addAll(RelOptUtil.getFieldTypeList(leftRel.getRowType())) | ||
| .addAll(RelOptUtil.getFieldTypeList(rightRel.getRowType())).build(); | ||
| final RexNode joinFilter = | ||
| RexUtil.composeConjunction(rexBuilder, | ||
| RexUtil.fixUp(rexBuilder, joinFilters, fieldTypes)); | ||
|
|
||
| // If nothing actually got pushed and there is nothing leftover, | ||
| // then this rule is a no-op | ||
| if (joinFilter.isAlwaysTrue() | ||
| && leftFilters.isEmpty() | ||
| && rightFilters.isEmpty() | ||
| && joinType == join.getJoinType()) { | ||
| return; | ||
| } | ||
|
|
||
| RelNode newJoinRel = | ||
| join.copy( | ||
| join.getTraitSet(), | ||
| joinFilter, | ||
| leftRel, | ||
| rightRel, | ||
| joinType, | ||
| join.isSemiJoinDone()); | ||
| call.getPlanner().onCopy(join, newJoinRel); | ||
| if (!leftFilters.isEmpty() && filter != null) { | ||
| call.getPlanner().onCopy(filter, leftRel); | ||
| } | ||
| if (!rightFilters.isEmpty() && filter != null) { | ||
| call.getPlanner().onCopy(filter, rightRel); | ||
| } | ||
|
|
||
| relBuilder.push(newJoinRel); | ||
|
|
||
| // Create a project on top of the join if some of the columns have become | ||
| // NOT NULL due to the join-type getting stricter. | ||
| relBuilder.convert(join.getRowType(), false); | ||
|
|
||
| // create a FilterRel on top of the join if needed | ||
| relBuilder.filter( | ||
| RexUtil.fixUp(rexBuilder, aboveFilters, | ||
| RelOptUtil.getFieldTypeList(relBuilder.peek().getRowType()))); | ||
| call.transformTo(relBuilder.build()); | ||
| } | ||
|
|
||
| private static List<RexNode> getConjunctions(Filter filter) { | ||
| List<RexNode> conjunctions = RelOptUtil.conjunctions(filter.getCondition()); | ||
| RexBuilder rexBuilder = filter.getCluster().getRexBuilder(); | ||
| for (int i = 0; i < conjunctions.size(); i++) { | ||
| RexNode node = conjunctions.get(i); | ||
| if (node instanceof RexCall) { | ||
| conjunctions.set(i, | ||
| RelOptUtil.collapseExpandedIsNotDistinctFromExpr((RexCall) node, rexBuilder)); | ||
| } | ||
| } | ||
| return conjunctions; | ||
| } | ||
| //@formatter:on | ||
|
|
||
| public static class PinotJoinConditionPushRule extends PinotFilterJoinRule<JoinConditionPushRule.Config> { | ||
| public static final PinotJoinConditionPushRule INSTANCE = | ||
| new PinotJoinConditionPushRule(JoinConditionPushRuleConfig.DEFAULT); | ||
|
|
||
| private PinotJoinConditionPushRule(JoinConditionPushRuleConfig config) { | ||
| super(config); | ||
| } | ||
|
|
||
| @Override | ||
| public void onMatch(RelOptRuleCall call) { | ||
| perform(call, null, call.rel(0)); | ||
| } | ||
| } | ||
|
|
||
| public static class PinotFilterIntoJoinRule extends PinotFilterJoinRule<FilterIntoJoinRuleConfig> { | ||
| public static final PinotFilterIntoJoinRule INSTANCE = | ||
| new PinotFilterIntoJoinRule(FilterIntoJoinRuleConfig.DEFAULT); | ||
|
|
||
| private PinotFilterIntoJoinRule(FilterIntoJoinRuleConfig config) { | ||
| super(config); | ||
| } | ||
|
|
||
| @Override | ||
| public void onMatch(RelOptRuleCall call) { | ||
| Filter filter = call.rel(0); | ||
| Join join = call.rel(1); | ||
| perform(call, filter, join); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
...anner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotProjectJoinTransposeRule.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pinot.calcite.rel.rules; | ||
|
|
||
| import org.apache.calcite.plan.RelOptRuleCall; | ||
| import org.apache.calcite.rel.core.Join; | ||
| import org.apache.calcite.rel.rules.ProjectJoinTransposeRule; | ||
| import org.apache.pinot.calcite.rel.hint.PinotHintOptions; | ||
|
|
||
|
|
||
| /** | ||
| * Similar to {@link ProjectJoinTransposeRule} but do not transpose project into right side of lookup join. | ||
| * | ||
| * TODO: Allow transposing project into left side of lookup join. | ||
| */ | ||
| public class PinotProjectJoinTransposeRule extends ProjectJoinTransposeRule { | ||
| public static final PinotProjectJoinTransposeRule INSTANCE = new PinotProjectJoinTransposeRule(Config.DEFAULT); | ||
|
|
||
| private PinotProjectJoinTransposeRule(Config config) { | ||
| super(config); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean matches(RelOptRuleCall call) { | ||
| Join join = call.rel(1); | ||
| return !PinotHintOptions.JoinHintOptions.useLookupJoinStrategy(join); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.