Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-4664 Time Python driver tests failing #120

Closed
wants to merge 4 commits into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Mar 6, 2023

No description provided.

@stoty stoty marked this pull request as draft March 6, 2023 11:24
@stoty
Copy link
Contributor Author

stoty commented Mar 6, 2023

This requires uncommitted Phoenix side changes.

@stoty
Copy link
Contributor Author

stoty commented Oct 30, 2023

This requires unreleased Phoenix side changes.

@richardantal
Copy link
Contributor

I ran the tests locally with python 3.12 and I got this error in test_timestamp:

E           AssertionError: Lists differ: [[1, [93 chars]12, 12, 1, 2)], [4, datetime.datetime(2015, 7,[30 chars]one]] != [[1, [93 chars]12, 13, 1, 2)], [4, datetime.datetime(2015, 7,[30 chars]one]]
E
E           First differing element 2:
E           [3, datetime.datetime(2015, 7, 12, 12, 1, 2)]
E           [3, datetime.datetime(2015, 7, 12, 13, 1, 2)]
E
E             [[1, datetime.datetime(2015, 7, 12, 13, 1, 2, 123000)],
E              [2, None],
E           -  [3, datetime.datetime(2015, 7, 12, 12, 1, 2)],
E           ?                                      ^
E
E           +  [3, datetime.datetime(2015, 7, 12, 13, 1, 2)],
E           ?                                      ^
E
E           -  [4, datetime.datetime(2015, 7, 12, 12, 1, 2, 123000)],
E           ?                                        ------
E
E           +  [4, datetime.datetime(2015, 7, 12, 13, 1, 2, 123000)],
E           ?                                      ++++++
E
E              [5, None]]

phoenixdb/tests/test_types.py:218: AssertionError

@stoty
Copy link
Contributor Author

stoty commented Jul 24, 2024

Thank you, it should be fixed with the new commit.

Copy link
Contributor

@richardantal richardantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoty stoty marked this pull request as ready for review July 25, 2024 05:49
@stoty
Copy link
Contributor Author

stoty commented Jul 25, 2024

merged manually

@stoty stoty closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants