Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add correctness check for read with if_xxx headers #5538

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 13, 2025

Which issue does this PR close?

None

Rationale for this change

Make sure users can read data correctly.

What changes are included in this PR?

Are there any user-facing changes?

Copy link

codspeed-hq bot commented Jan 13, 2025

CodSpeed Performance Report

Merging #5538 will not alter performance

Comparing add-correct-check (dcffc16) with main (85c3803)

Summary

✅ 73 untouched benchmarks

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 13, 2025

Thank you @WenyXu for the review.

@Xuanwo Xuanwo merged commit 41c72d8 into main Jan 13, 2025
279 checks passed
@Xuanwo Xuanwo deleted the add-correct-check branch January 13, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants