Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second improvement on this functionality with increase the security by analyse each script to control the presence of potential code injection. The regexp to control is a property: security.deniedScriptletsTokens. If a script match the regexp, OFBiz raise in log an alert with the script and the script hash. The script is disabled and can't run. If you have a safe script who is matched by the regexp, you can add the hash given by OFBiz on the property: security.allowedScriptletHashes
gilPts
reviewed
Oct 10, 2024
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java
Outdated
Show resolved
Hide resolved
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java
Outdated
Show resolved
Hide resolved
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java
Outdated
Show resolved
Hide resolved
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java
Outdated
Show resolved
Hide resolved
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java
Outdated
Show resolved
Hide resolved
|
|
||
| /** | ||
| * Load the list of script exception that we autorise to run despite the security risk | ||
| * @return Pattern init by the regExp security.deniedScriptletsTokens |
There was a problem hiding this comment.
Suggested change
| * @return Pattern init by the regExp security.deniedScriptletsTokens | |
| * @return Pattern init by the regExp security.allowedScriptletHashes |
…Util.java Co-authored-by: Gil Portenseigne <[email protected]>
…Util.java Co-authored-by: Gil Portenseigne <[email protected]>
…Util.java Co-authored-by: Gil Portenseigne <[email protected]>
…Util.java Co-authored-by: Gil Portenseigne <[email protected]>
…Util.java Co-authored-by: Gil Portenseigne <[email protected]>
nmalin
commented
Oct 10, 2024
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java
Outdated
Show resolved
Hide resolved
Improve reg exp to support more possible code injection
Improve reg exp to support more possible code injection
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second improvement on this functionality with increase the security by analyse each script to control the presence of potential code injection.
The regexp to control is a property: security.deniedScriptletsTokens.
If a script match the regexp, OFBiz raise in log an alert with the script and the script hash. The script is disabled and can't run.
If you have a safe script who is matched by the regexp, you can add the hash given by OFBiz on the property: security.allowedScriptletHashes