Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14068 Fix Domain Name Handling for SFTP Proxy Access #9649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-14068 Corrects the behavior of SFTP processors when configured for proxy access using a DNS name.

The current implementation of the SSHJ SSHClient always attempts to resolve DNS names to IP addresses when constructing an InetSocketAddress for the socket connection. This behavior is not ideal when connecting through a proxy server because NiFi may not be able to resolve the DNS address and should rely on the proxy server to perform DNS resolution.

The revised implementation introduces an extension of SSHClient that overrides the makeInetSocketAddress method to return an unresolved address when the client is configured with a Proxy Socket Factory. The unresolved status instructs HTTP and SOCKS proxy socket clients to send a DNS address instead of a resolved IP address.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Added Standard extension of SSHClient with Socket Address creation based on proxy configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant