Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14171: Honor catalog/schema field in UpdateDatabaseTable when executing ALTER table #9645

Closed
wants to merge 1 commit into from

Conversation

gadomsky
Copy link

NIFI-14171: Honor catalog/schema field in UpdateDatabaseTable when executing ALTER table

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this correction @gadomsky.

PR #9640 includes more significant refactoring of this behavior, and also addresses the issue with qualifying tables in ALTER statements. With changes in that pull request, it looks like these changes would be unnecessary.

@gadomsky
Copy link
Author

@exceptionfactory Oh, I didn't see that PR. In that case I'm closing this one, thanks!

@gadomsky gadomsky closed this Jan 17, 2025
@exceptionfactory
Copy link
Contributor

@exceptionfactory Oh, I didn't see that PR. In that case I'm closing this one, thanks!

Sounds good, thanks again for highlighting this issue @gadomsky, I linked the Jira issues so we can close this Jira issue when the other pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants