Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14134 - add support for JSON file upload to CLI pg-import #9611

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Jan 7, 2025

Summary

NIFI-14134 - add support for JSON file upload to CLI pg-import

Currently, in the CLI,

./cli.sh nifi pg-import

only supports creating a process group based on references to a versioned flow through a Registry Client.

In, the UI, it is possible to drag and drop a process group onto the canvas and provide a JSON file definition to create a new process group based on the flow definition. This approach should also be supported by the CLI command pg-import.

With this change, it is now possible to execute a command like below:

$ ./bin/cli.sh nifi pg-import -i /my/flow.json -p nifi-cli.properties
42357e56-0194-1000-7b1f-ba830cac1de6

And it returns the UUID of the process group created with the uploaded JSON flow definition.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@pvillard31
Copy link
Contributor Author

Thanks for the review @dan-s1 - I just pushed a commit to address your comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants