NIFI-14116 Add PMD Rule UnnecessaryVarargsArrayCreation

[exceptionfactory]

Summary

NIFI-14116 Adds the UnnecessaryVarargsArrayCreation rule to the standard PMD configuration.

This rule detects unnecessary array creation where variable arguments can be used. This is particularly useful for log statements. Changes build on work to standardize code conventions across the repository, and include changes to bring remaining references in line with rule requirements.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[joewitt]

Is a bit odd to me how long static analysis is taking here. Trying locally