-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-13651 moved framework extension modules to new framework extensions module #9169
Conversation
Key points:
nifi-property-utils and nifi-properties should fine their way out of the root lib directory. They should at most be in the nifi framework nar and the framework extensions should likely have the framework nar as their parent to be bound at that level. But more work is needed to understand the relationship of the bootstrap folder and the properties to the framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting together these changes @joewitt, placing framework-level extensions in a separate category provides a very helpful distinction. The general approach looks good, I plan to take a closer look, but this appears to cover the applicable modules on initial review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joewitt Reviewing other modules in nifi-extensions-bundles
, the nifi-py4j-bundle
is one other candidate for moving to the nifi-framework-extensions
because it supports the Python Processor integration at the framework level.
@joewitt @exceptionfactory Thoughts on moving |
@bbende That's a good point, I agree the |
rgr. will grab nifi-py4j-bundle and nifi-framework-kubernetes-bundle to move there as well |
breaking apart the 'nifi-py4j-bundle' as a few modules go together in a framework sense. And a few modules go together as examples/tests/impls as an extension. The nifi-py4j-bridge component actually combines core framework elements and ties to extension concepts such as 'records' and such. Until we promote 'records' as part of the official/formal API this seems like the right place for these few. Will have that in the next commit but the next commit will squash and rebase to latest main as well |
ok i think i addressed each of the suggestions. Full clean build and all the trimmings works as expected. |
…ork-bundle and ensure nothing in nifi-extension-bundles references nifi-property-utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the adjustments @joewitt, this is a helpful restructuring of framework-specific extension modules. +1 merging
Summary
NIFI-13651
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation