Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13372 Add processor DeleteSFTP #9012

Closed
wants to merge 3 commits into from

Conversation

EndzeitBegins
Copy link
Contributor

@EndzeitBegins EndzeitBegins commented Jun 26, 2024

Summary

Adds new processor DeleteSFTP to the bundle standard-processors.

See issue NIFI-13372 for the motivation behind the addition.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@EndzeitBegins EndzeitBegins marked this pull request as draft June 27, 2024 06:06
@EndzeitBegins
Copy link
Contributor Author

I just noticed that ListSFTP unlike ListFile does not populate both path and absolute.path but only path instead.

I'll adjust the PR accordingly.

@EndzeitBegins
Copy link
Contributor Author

EndzeitBegins commented Jun 27, 2024

PR adjusted accordingly.
The implementation is inspired by both that of DeleteFile and PutSFTP.

I would appreciate a review. 🙂

@EndzeitBegins EndzeitBegins marked this pull request as ready for review June 27, 2024 16:32
@EndzeitBegins
Copy link
Contributor Author

Based on this discussion I added a commit that removes the addition of exception details as FlowFile attributes.

I also rebased on main as several commits were merged since this PR was opened.

@asfgit asfgit closed this in 821e5d2 Sep 9, 2024
@EndzeitBegins EndzeitBegins deleted the NIFI-13372 branch September 9, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants