[NIFI-12415] Counters #8077
Merged
[NIFI-12415] Counters #8077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* populate counter the table. * support counter reset. * filtering by name and by context * sorting, including initial sort * added basic tests
|
Will review... |
mcgilman
reviewed
Nov 29, 2023
| } | ||
|
|
||
| @Output() resetCounter: EventEmitter<CounterEntity> = new EventEmitter<CounterEntity>(); | ||
| @Output() selectCounter: EventEmitter<CounterEntity> = new EventEmitter<CounterEntity>(); |
There was a problem hiding this comment.
Good catch. No it is not needed.
| import { MatTableDataSource } from '@angular/material/table'; | ||
| import { MatSort } from '@angular/material/sort'; | ||
| import { FormBuilder, FormGroup } from '@angular/forms'; | ||
| import { debounceTime, filter } from 'rxjs'; |
There was a problem hiding this comment.
I think filter is unused.
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { AfterViewInit, Component, EventEmitter, Input, OnInit, Output, ViewChild } from '@angular/core'; |
There was a problem hiding this comment.
I think OnInit is unused.
rfellows
added
the
new ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12415
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation