[NIFI-13656] allow enter button to submit create PG and create Port f…

…orm (#9181) * [NIFI-13656] allow enter button to submit create PG and create Port form * restore scrolling for hints in codemirrors in update attribute * fix unit tests * update unit test * remove duplicate imports This closes #9181
apache · Aug 20, 2024 · 8919955 · 8919955
1 parent 7f41bc1
commit 8919955
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 7 deletions.
diff --git a/...bundle/nifi-update-attribute-ui/src/main/webapp/js/jquery/nfeditor/languages/nfeditor.css b/...bundle/nifi-update-attribute-ui/src/main/webapp/js/jquery/nfeditor/languages/nfeditor.css
@@ -15,6 +15,10 @@
  * limitations under the License.
  */
 
+ul.CodeMirror-hints {
+    overflow-y: scroll;
+}
+
 div.el-section {
     margin: 5px 0;
 }

diff --git a/...rc/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/canvas/canvas.component.spec.ts b/...rc/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/canvas/canvas.component.spec.ts
@@ -16,7 +16,8 @@
  */
 
 import { ComponentFixture, TestBed } from '@angular/core/testing';
-
+import { MatSidenavModule } from '@angular/material/sidenav';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { Canvas } from './canvas.component';
 import { provideMockStore } from '@ngrx/store/testing';
 import { initialState } from '../../state/flow/flow.reducer';
@@ -30,9 +31,7 @@ import { HeaderComponent } from './header/header.component';
 import { FooterComponent } from './footer/footer.component';
 import { canvasFeatureKey } from '../../state';
 import { flowFeatureKey } from '../../state/flow';
-import { MatSidenavModule } from '@angular/material/sidenav';
 import { FlowAnalysisDrawerComponent } from './header/flow-analysis-drawer/flow-analysis-drawer.component';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { CanvasActionsService } from '../../service/canvas-actions.service';
 
 describe('Canvas', () => {
@@ -60,6 +59,8 @@ describe('Canvas', () => {
                 ContextMenu,
                 MatSidenavModule,
                 NoopAnimationsModule,
+                MatSidenavModule,
+                NoopAnimationsModule,
                 MockComponent(GraphControls),
                 MockComponent(HeaderComponent),
                 MockComponent(FooterComponent),

diff --git a/...i/src/app/pages/flow-designer/ui/canvas/items/port/create-port/create-port.component.html b/...i/src/app/pages/flow-designer/ui/canvas/items/port/create-port/create-port.component.html
@@ -61,7 +61,7 @@ <h2 mat-dialog-title>Create New {{ portTypeLabel }}</h2>
             <button mat-button mat-dialog-close>Cancel</button>
             <button
                 [disabled]="!createPortForm.dirty || createPortForm.invalid || saving.value"
-                type="button"
+                type="submit"
                 color="primary"
                 (click)="createPort()"
                 mat-button>

diff --git a/...er/ui/canvas/items/process-group/create-process-group/create-process-group.component.html b/...er/ui/canvas/items/process-group/create-process-group/create-process-group.component.html
@@ -77,7 +77,7 @@ <h2 mat-dialog-title>Create Process Group</h2>
             <button mat-button mat-dialog-close>Cancel</button>
             <button
                 [disabled]="!createProcessGroupForm.dirty || createProcessGroupForm.invalid || saving.value"
-                type="button"
+                type="submit"
                 color="primary"
                 (click)="createProcessGroup()"
                 mat-button>

diff --git a/...nifi/src/app/ui/common/property-table/editors/combo-editor/combo-editor.component.spec.ts b/...nifi/src/app/ui/common/property-table/editors/combo-editor/combo-editor.component.spec.ts
@@ -122,6 +122,11 @@ describe('ComboEditor', () => {
     it('should create', () => {
         if (item) {
             component.item = item;
+            component.parameterConfig = {
+                supportsParameters: false,
+                parameters: null
+            };
+
             fixture.detectChanges();
 
             expect(component).toBeTruthy();
@@ -131,6 +136,11 @@ describe('ComboEditor', () => {
     it('verify combo value', () => {
         if (item) {
             component.item = item;
+            component.parameterConfig = {
+                supportsParameters: false,
+                parameters: null
+            };
+
             fixture.detectChanges();
 
             const formValue = component.comboEditorForm.get('value')?.value;
@@ -149,6 +159,11 @@ describe('ComboEditor', () => {
             item.descriptor.required = false;
 
             component.item = item;
+            component.parameterConfig = {
+                supportsParameters: false,
+                parameters: null
+            };
+
             fixture.detectChanges();
 
             const formValue = component.comboEditorForm.get('value')?.value;
@@ -168,6 +183,11 @@ describe('ComboEditor', () => {
             item.descriptor.defaultValue = undefined;
 
             component.item = item;
+            component.parameterConfig = {
+                supportsParameters: false,
+                parameters: null
+            };
+
             fixture.detectChanges();
 
             const formValue = component.comboEditorForm.get('value')?.value;
@@ -185,7 +205,11 @@ describe('ComboEditor', () => {
             item.value = '#{one}';
 
             component.item = item;
-            component.parameters = parameters;
+            component.parameterConfig = {
+                supportsParameters: true,
+                parameters
+            };
+
             fixture.detectChanges();
             await fixture.whenStable();
 
@@ -207,7 +231,11 @@ describe('ComboEditor', () => {
             item.value = '#{three}';
 
             component.item = item;
-            component.parameters = parameters;
+            component.parameterConfig = {
+                supportsParameters: true,
+                parameters
+            };
+
             fixture.detectChanges();
             await fixture.whenStable();