Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13495: PutChroma 'unexpected keyword argument' error #4

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

krisztina-zsihovszki
Copy link
Contributor

Summary

NIFI-13495

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and correcting this issue @krisztina-zsihovszki, the specific comment for ignoring the unused argument is a good approach. +1 merging

@exceptionfactory
Copy link
Contributor

exceptionfactory commented Jul 4, 2024

@krisztina-zsihovszki The initial commit to this branch does not have an associated signature. As a new repository, signed commits are required. If you can sign the commit and push an update, I can proceed to merge.

@krisztina-zsihovszki
Copy link
Contributor Author

@exceptionfactory Please check if the forced pushed commit is signed properly.

@exceptionfactory
Copy link
Contributor

Thanks for updating the branch with the signed commit @krisztina-zsihovszki, looks good!

@exceptionfactory exceptionfactory merged commit c4a8860 into apache:main Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants