Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Blues Wireless note-c library support and example application. #3300

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

ujur007
Copy link
Contributor

@ujur007 ujur007 commented Sep 1, 2024

Hi,
I have added support for Blues Wireless note-c library. in /net/cellular. Also, I have added an example application inside apps/blues-wireless to get location data based on GPS.

I took the inspiration from note-zephyr repository.

net/cellular/blues/pkg.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ujur007 If you change first commit to just pkg.yml with repository description checks for license and style from blue-c will not be done.
Then only application code will need to adhere to mynewt coding style before it can be merged.

@ujur007 ujur007 force-pushed the master branch 2 times, most recently from d8081cb to 8a133b2 Compare September 3, 2024 12:08
@github-actions github-actions bot added size/m and removed size/xl labels Sep 3, 2024
Copy link
Contributor

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting issues that somehow were not detected by automatic style checker.

apps/blues-wireless/src/main.c Outdated Show resolved Hide resolved
apps/blues-wireless/src/note_c_hooks.c Outdated Show resolved Hide resolved
apps/blues-wireless/src/note_c_hooks.c Outdated Show resolved Hide resolved
apps/blues-wireless/src/note_c_hooks.c Outdated Show resolved Hide resolved
apps/blues-wireless/src/note_c_hooks.c Outdated Show resolved Hide resolved
apps/blues-wireless/src/note_c_hooks.c Outdated Show resolved Hide resolved
apps/blues-wireless/src/note_c_hooks.c Outdated Show resolved Hide resolved
apps/blues-wireless/src/note_c_hooks.c Outdated Show resolved Hide resolved
@ujur007
Copy link
Contributor Author

ujur007 commented Sep 8, 2024

have pushed the updated code.

@kasjer
Copy link
Contributor

kasjer commented Sep 9, 2024

@ujur007 single empty lines are fine if they make code more readable.
Extra lines after { and before } are not allowed.
Empty lines at the end of file are required.
Line length is enforced by style checker and is currently set to 119 characters.

@ujur007
Copy link
Contributor Author

ujur007 commented Sep 9, 2024

Ok. Updated the code.

@kasjer
Copy link
Contributor

kasjer commented Sep 9, 2024

@ujur007 I wrote Empty lines at the end of file are required. it should be empty line (single line)

@ujur007
Copy link
Contributor Author

ujur007 commented Sep 9, 2024

Okay now?

@kasjer
Copy link
Contributor

kasjer commented Sep 9, 2024

Okay now?

Check details of Compliance check / Coding style (pull_request) to see what else is not ok. There seems to be red cross.

@ujur007
Copy link
Contributor Author

ujur007 commented Sep 9, 2024

There was extra space I think for that it has failed. Out of three files, two were ok.

Copy link
Contributor

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujur007
Copy link
Contributor Author

ujur007 commented Sep 9, 2024

Thank you for your support. My first PR.

@kasjer kasjer requested a review from sjanc September 9, 2024 12:17
@sjanc sjanc merged commit 5065017 into apache:master Sep 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants