simplify jflex grammars by using difference rather than negation #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses a new jflex feature (jflex-de/jflex#654) to simplify emoji processing in the grammar. We can do a set difference rather than workaround it with complement + demorgan stuff.
It is cosmetic: doesn't change the resulting tokenizers (see diff), but makes the emoji parts easier to read.
bonus: major speed up to regenerating that huge UAX29UrlEmail DFA.
Before:
After:
This was suggested by jflex developers to help with the very-slow-regeneration on jflex-de/jflex#715 . It doesn't solve all of our problems there, but it makes things a lot less painful :)