Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace special-casing of DocBaseBitSetIterator with #intoBitSet. #14139

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Jan 14, 2025

This takes advantage of the new #intoBitSet API to remove special casing of DocBaseBitSetIterator in FixedBitSet#or(DocIdSetIterator).

This takes advantage of the new `#intoBitSet` API to remove special casing of
`DocBaseBitSetIterator` in `FixedBitSet#or(DocIdSetIterator)`.
@jpountz jpountz added this to the 10.2.0 milestone Jan 14, 2025
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpountz jpountz merged commit 04eecb0 into apache:main Jan 21, 2025
5 checks passed
@jpountz jpountz deleted the simplify_doc_base_bit_set_iterator branch January 21, 2025 09:38
@jpountz
Copy link
Contributor Author

jpountz commented Jan 21, 2025

Thanks @ChrisHegarty

jpountz added a commit that referenced this pull request Jan 21, 2025
…#14139)

This takes advantage of the new `#intoBitSet` API to remove special casing of
`DocBaseBitSetIterator` in `FixedBitSet#or(DocIdSetIterator)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants