Implement ACORN-1 search for HNSW #14085
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Playing around with some ideas from ACORN-1 to improve filtered HNSW search. The ideas are:
I benchmarked using Cohere/wikipedia-22-12-en-embeddings with params:
Here are some results:
Baseline:
Candidate (this code):
Pros: significantly faster for selective filters.
Cons: slightly worse recall across the board, slightly slower for inclusive filters.
There's a lot to play around with here, this code represents the best results I got with this testing. One thing that must be tested is correlation between filter and query vector (this is discussed and tested in the paper). luceneutil only offers zero correlation at the moment, so I'm working on adding a knob to turn there for future benchmarks.
Code should also be cleaned up, but for me, keeping everything in one method makes it easier to read the changes.