replace Map<String,Object> with IntObjectHashMap for DV producer #13961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
requested changes
Oct 29, 2024
| @@ -377,7 +376,7 @@ private static class SlowCompositeDocValuesProducerWrapper extends DocValuesProd | |||
| private final CodecReader[] codecReaders; | |||
| private final DocValuesProducer[] producers; | |||
| private final int[] docStarts; | |||
| private final Map<String, OrdinalMap> cachedOrdMaps = new HashMap<>(); | |||
| private final IntObjectHashMap<OrdinalMap> cachedOrdMaps = new IntObjectHashMap<>(); | |||
There was a problem hiding this comment.
I would rather keep this one keyed on the String field name since there's some ambiguity about whether it doc values sohuld be retrieved by segment field infos or by merged field infos.
There was a problem hiding this comment.
Reverted. Btw, I wonder if we should change the DocValuesProducer/NormsProducer API to take a String rather than a FieldInfo right now as mentioned in issue#13805 and issue#13685.
jpountz
approved these changes
Oct 29, 2024
jpountz
pushed a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add back #13686, which is reverted previously due to #13805.