Add tooling back on 9.10.x branch to generate int7_hnsw.9.10.zip bwc index #13879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
reviewed
Oct 9, 2024
| @@ -82,6 +82,16 @@ public void testCreateSortedIndex() throws IOException { | |||
| sortedTest.createBWCIndex(); | |||
| } | |||
|
|
|||
| public void testCreateInt7HNSWIndices() throws IOException { | |||
There was a problem hiding this comment.
should we add this to the back compat script? And if so then there could be a collision with future versions.
There was a problem hiding this comment.
Hmm I think we can just rename int8_hnsw -> int7_hnsw in addBackCompatIndexes.py? But I would do that change on our latest branches (9.12.x, 10.x, 10.0.x) as a separate follow-on PR? This PR is just targetting 9.10.x branch in case we ever need to regen 9.10.x bwc indices again (hope not!).
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff from #13867 to add the tooling back onto
branch_9_10in case we ever need to regenerate theint7_hnsw.9.10.0.zipbwc index again.