Allow reading / writing binary stored fields as DataInput #12581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
changed the title
romseygeek
approved these changes
Sep 21, 2023
| public void binaryField(FieldInfo fieldInfo, DataInput value, int length) throws IOException { | ||
| writeField(remap(fieldInfo), value, length); | ||
| } | ||
|
|
||
| @Override | ||
| public void binaryField(FieldInfo fieldInfo, byte[] value) throws IOException { | ||
| // TODO: can we avoid new BR here? |
There was a problem hiding this comment.
Does this ever get called now?
There was a problem hiding this comment.
Nope, it should not be called, maybe we should assert that it doesn't get called?
There was a problem hiding this comment.
Actually the SimpleTextCodec codec is using it.
iverase
added a commit
that referenced
this pull request
Sep 25, 2023
This commit adds the possibility to read / write binary stored values using a DataInput and the number of bytes. By default the implementations will allocate those bytes in a newly created byte array and call the already existing method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to handle binary data on stored fields is via byte arrays (wrapped as BytesRef). THis means we are allocating a new byte array everytime we read the value which is wasteful and it can be problematic as those arrays can be humongous and add pressure to the GC.
In this PR we proposed to add the possibility to read / write binary stored values using a DataInput and the number of bytes. By default the implementations will allocate those bytes in a newly created byte array and call the already existing method.
This should speed up the merging of stored fields as we are not using an intermediate data structure any longer and allow implementoirs to read the binary fields without having to allocate a byte array.
EDIT: merges may be faster if merge strategy is
MergeStrategy.VISITORcloses #12556