Cherrypick lock backoff retry to 3.9 #18485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadonna
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Thanks for the PR, @aliehsaeedii !
I have one question.
Additionally, checkstyle is failing due to an unused import.
| @@ -4578,48 +4626,6 @@ public void shouldNotFailForTimeoutExceptionOnConsumerCommit() { | |||
| verify(consumer, times(2)).commitSync(any(Map.class)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldNotFailForTimeoutExceptionOnCommitWithEosAlpha() { | |||
cadonna
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Thanks for the update, @aliehsaeedii !
I have one minor comment.
| @@ -364,7 +364,6 @@ synchronized boolean lock(final TaskId taskId) { | |||
| } else { | |||
| lockedTasksToOwner.put(taskId, Thread.currentThread()); | |||
| // make sure the task directory actually exists, and create it if not | |||
There was a problem hiding this comment.
I just noticed that this comment does not make sense anymore since the following line is removed. This also applies to trunk. Could you please remove the comment here and open a PR to remove the comment for trunk?
cadonna
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the commits of this and this PR to
3.9.The above-listed two PRs aim at implementing exponential back off retry for state directory lock to increase the time between two consecutive attempts of acquiring the lock.