KAFKA-18399 Remove ZooKeeper from KafkaApis (10/N): ALTER_CLIENT_QUOTAS, handleAllocateProducerIdsRequest #18465
Conversation
…dleAllocateProducerIdsRequest
github-actions
bot
added
triage
| requestHelper.sendResponseMaybeThrottle(request, throttleTimeMs => | ||
| new AllocateProducerIdsResponse(producerIdsResponse.setThrottleTimeMs(throttleTimeMs))) | ||
| ) | ||
| throw KafkaApis.shouldNeverReceive(request) |
There was a problem hiding this comment.
I think we shouldn't handle it like this - this is one of the request types that is only handled by the controller listener (now that zk is gone):
"listeners": ["zkBroker", "controller"]
So, we should have generic logic that handles that automatically before it gets here. We can probably just delete this whole method.
There was a problem hiding this comment.
Same for handleAlterClientQuotasRequest.
There was a problem hiding this comment.
So, we should have generic logic that handles that automatically before it gets here. We can probably just delete this whole method.
totally agree that we should have a generic logic for those zk-related handler. The socket server can reject the zk-related requests automatically, and we can rewrite maybeForwardToController to throw KafkaApis.shouldAlwaysForward automatically. With those change, those zk-related handlers can be deleted directly.
In short, the line case ApiKeys.ALLOCATE_PRODUCER_IDS => handleAllocateProducerIdsRequest(request) can be removed.
There was a problem hiding this comment.
Yes, exactly. We can also remove the zk listener from the json files and the socket server will automatically do the right thing, I believe (i.e. it already has logic for that).
There was a problem hiding this comment.
We can also remove the zk listener from the json files
https://issues.apache.org/jira/browse/KAFKA-18399
Committer Checklist (excluded from commit message)