Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-11370 : add utils in oak-commons to check equality of 2 iterables #1968

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

OAK-11370 : add utils in oak-commons to check equality of 2 iterables #1968

wants to merge 2 commits into from

Conversation

t-rana
Copy link
Contributor

@t-rana t-rana commented Jan 9, 2025

No description provided.

reschke
reschke reviewed Jan 9, 2025
View reviewed changes
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/collections/CollectionUtils.java
return false;
}
}

Copy link
Contributor

@reschke reschke Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put that into an "else" (return values from the same nesting level).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reschke reschke reschke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-rana @reschke