Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated DevModeTestUtils with DevModeClient #3830

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rsvoboda
Copy link

Replace deprecated DevModeTestUtils with DevModeClient

@domhanak domhanak requested review from fjtirado and gmunozfe January 22, 2025 11:21
@kie-ci3
Copy link
Contributor

kie-ci3 commented Jan 22, 2025

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3830 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3830/1/display/redirect

Test results:

  • PASSED: 3524
  • FAILED: 1

Those are the test failures:

PR check / Build projects / org.kie.kogito.it.JDBCOptimisticLockingIT.testAsyncWIH Assertion condition defined as a org.kie.kogito.it.PersistenceTest 1 expectation failed.
Expected status code <404> but was <200>.
within 10 seconds.

@rsvoboda
Copy link
Author

org.kie.kogito.it.JDBCOptimisticLockingIT.testAsyncWIH fail doesn't seem to be related to the change

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution @rsvoboda !

@gmunozfe
Copy link
Contributor

Failing test org.kie.kogito.it.JDBCOptimisticLockingIT.testAsyncWIH seems unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants